Remove the log statement#5293
Closed
brson wants to merge 3 commits into
Closed
Conversation
Contributor
|
+1. Now that you can do |
Contributor
Author
Contributor
|
I'm ok removing the expression; it seems like the long term fix (not just renaming) requires thinking about either globals or fast tls. |
We can't quite remove logging from the language, but this hides the keyword.
bors
added a commit
that referenced
this pull request
Mar 13, 2013
r? @graydon This removes `log` from the language. Because we can't quite implement it as a syntax extension (probably need globals at the least) it simply renames the keyword to `__log` and hides it behind macros. After this the only way to log is with `debug!`, `info!`, etc. I figure that if there is demand for `log!` we can add it back later. I am not sure that we ever agreed on this course of action, though I *think* there is consensus that `log` shouldn't be a statement.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
…ansch don't emit lifetime lint warnings for code inside macros. Fixes rust-lang#5283 changelog: Don't emit lifetime lint warnings for code inside macros.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @graydon
This removes
logfrom the language. Because we can't quite implement it as a syntax extension (probably need globals at the least) it simply renames the keyword to__logand hides it behind macros.After this the only way to log is with
debug!,info!, etc. I figure that if there is demand forlog!we can add it back later.I am not sure that we ever agreed on this course of action, though I think there is consensus that
logshouldn't be a statement.